It should be thin but sturdy — Too thick, and the wearer will notice the extra layers at that point. Too thin, and keys/pens will wear a hole too quickly.
There's fabric that's specially made for lining pockets, [2][3] but that's really only necessary for the nicest garments.
Bandana fabric works great.
The thickest fabric you might want to use is quilting cotton.